might this have been causing eclipse-xtext/xtext#3708

@jjohnstn this seems to break a typename like

org.eclipse.xtext.common.types.testSetups.$StartsWithDollar

package org.eclipse.xtext.common.types.testSetups;

public class $StartsWithDollar {

	public static class Builder {}
	
}

cc @iloveeclipse

@cdietrich : looking at eclipse-xtext/xtext#3708, I don't understand if this is something which affects the internal Xtext handling of classes with dollar?

The given code name seem to be properly represented in JDT AST and editor/compiler show no problems too:

Also bytecode shows nothing unexpected:

@jjohnstn this seems to break a typename like

org.eclipse.xtext.common.types.testSetups.$StartsWithDollar

package org.eclipse.xtext.common.types.testSetups;

public class $StartsWithDollar {

	public static class Builder {}
	
}

cc @iloveeclipse

I'll take a look.

@iloveeclipse I have posted: #5073 This fixes the new problems reported in Xtext and still fixes the original issue whereby importing from a package with dollar in the name wasn't working. I will request a review from you there.

This fixes the new problems reported in Xtext and still fixes the original issue whereby importing from a package with dollar in the name wasn't working

Could you explain which exact poblem Xtext had with recent changes?

@iloveeclipse please check the failing https://github.com/eclipse-xtext/xtext/pull/3710/changes
eclipse-xtext/xtext#3708 has some code pointers

@szarnekow you might be able to explain more on the details